Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spec raising syntax error when defining yield in singleton class #873

Merged
merged 1 commit into from
Oct 11, 2021
Merged

add spec raising syntax error when defining yield in singleton class #873

merged 1 commit into from
Oct 11, 2021

Conversation

HeroProtagonist
Copy link
Contributor

relates to #823

yield in singleton class definitions in methods is now a SyntaxError
instead of a warning. yield in a class definition outside of a method
is now a SyntaxError instead of a LocalJumpError. [Feature #15575]

eregon
eregon approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new spec!

@eregon eregon merged commit 3521453 into ruby:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeroProtagonist @eregon